> On 2009-09-11 18:47:48, Matt Rogers wrote: > > the screenshot for the busy icon looks a bit off, since it's the old kopete > > icon. is that how it actually looks or does it look more like the away? If > > it's more like the away, then please commit this.
Well, this is Oxygen's user-busy icon. What if we change to im-user-* oxygen icons in the contactlist? - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1361/#review2296 ----------------------------------------------------------- On 2009-08-23 14:19:18, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1361/ > ----------------------------------------------------------- > > (Updated 2009-08-23 14:19:18) > > > Review request for Kopete. > > > Summary > ------- > > When I'm chatting using Kopete, sometimes I have to go then I mark myself to > away. When I come back I never recall that I marked myself away and then I > never know if I'm marked as busy or away, then people blame me and make me > cry (well they don't but makes my point more dramatic). > > This patch tries to fix that. Note that I had to go through all plugins and > change the state equivalent to busy to use the global ::Busy status. > > > This addresses bug 179080. > https://bugs.kde.org/show_bug.cgi?id=179080 > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp 1014660 > trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp > 1014660 > trunk/KDE/kdenetwork/kopete/kopete/kopetedbusinterface.cpp 1014660 > trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1014660 > trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 1014660 > trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1014660 > trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1014660 > trunk/KDE/kdenetwork/kopete/libkopete/kopeteonlinestatus.h 1014660 > trunk/KDE/kdenetwork/kopete/libkopete/kopeteonlinestatus.cpp 1014660 > trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticscontact.cpp > 1014660 > trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdialog.cpp 1014660 > trunk/KDE/kdenetwork/kopete/plugins/webpresence/webpresenceplugin.cpp > 1014660 > trunk/KDE/kdenetwork/kopete/protocols/bonjour/bonjouraccount.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduprotocol.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwprotocol.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberprotocol.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/meanwhile/meanwhileprotocol.cpp > 1014660 > trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimaccount.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimstatusmanager.cpp > 1014660 > trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqstatusmanager.cpp > 1014660 > trunk/KDE/kdenetwork/kopete/protocols/skype/skypeprotocol.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedaccount.h 1014660 > trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedaccount.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedprotocol.h 1014660 > trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedprotocol.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/winpopup/wpaccount.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmprotocol.cpp 1014660 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahooprotocol.cpp 1014660 > > Diff: http://reviewboard.kde.org/r/1361/diff > > > Testing > ------- > > Use it ever since (WLM and Jabber). Changing status works just fine. > Ran the Kopete tests, I don't think this is being tested, though. > > > Screenshots > ----------- > > online > http://reviewboard.kde.org/r/1361/s/185/ > away > http://reviewboard.kde.org/r/1361/s/186/ > busy > http://reviewboard.kde.org/r/1361/s/187/ > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
