----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1361/ -----------------------------------------------------------
(Updated 2009-08-23 12:30:49.608665) Review request for Kopete. Changes ------- Filled testing description Summary ------- When I'm chatting using Kopete, sometimes I have to go then I mark myself to away. When I come back I never recall that I marked myself away and then I never know if I'm marked as busy or away, then people blame me and make me cry (well they don't but makes my point more dramatic). This patch tries to fix that. Note that I had to go through all plugins and change the state equivalent to busy to use the global ::Busy status. This addresses bug 179080. https://bugs.kde.org/show_bug.cgi?id=179080 Diffs ----- trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp 1012131 trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 1012131 trunk/KDE/kdenetwork/kopete/kopete/kopetedbusinterface.cpp 1012131 trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1012131 trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 1012131 trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1012131 trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1012131 trunk/KDE/kdenetwork/kopete/libkopete/kopeteonlinestatus.h 1012131 trunk/KDE/kdenetwork/kopete/libkopete/kopeteonlinestatus.cpp 1012131 trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticscontact.cpp 1012131 trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdialog.cpp 1012131 trunk/KDE/kdenetwork/kopete/plugins/webpresence/webpresenceplugin.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/bonjour/bonjouraccount.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduprotocol.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwprotocol.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberprotocol.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/meanwhile/meanwhileprotocol.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimaccount.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimstatusmanager.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqstatusmanager.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/skype/skypeprotocol.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedaccount.h 1012131 trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedaccount.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedprotocol.h 1012131 trunk/KDE/kdenetwork/kopete/protocols/testbed/testbedprotocol.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/winpopup/wpaccount.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmprotocol.cpp 1012131 trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahooprotocol.cpp 1012131 Diff: http://reviewboard.kde.org/r/1361/diff Testing (updated) ------- Use it ever since (WLM and Jabber). Changing status works just fine. Ran the Kopete tests, I don't think this is being tested, though. Thanks, Aleix _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel