> On 2009-08-21 17:57:36, Tiago Salem Herrmann wrote: > > trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp, line 610 > > <http://reviewboard.kde.org/r/1359/diff/1/?file=10258#file10258line610> > > > > I think you can remove this line, as it.value()->isOnline() will filter > > only the online contacts.
I agree more UI is needed (actually I think that the whole conversation window needs some rethinking, there's some GSoC on that, isn't it?), but what's not reliable is to have to ask the users to change to Online so that we can add them to the conversations. This makes Kopete look weak IMHO. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1359/#review2114 ----------------------------------------------------------- On 2009-08-19 22:12:43, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1359/ > ----------------------------------------------------------- > > (Updated 2009-08-19 22:12:43) > > > Review request for Kopete. > > > Summary > ------- > > Instead of just showing the Online contacts, we show the contacts that are > not offline. > > I'd suggest to backport that to the 4.3 branch as well. > > > This addresses bug 203585. > https://bugs.kde.org/show_bug.cgi?id=203585 > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp 1012131 > > Diff: http://reviewboard.kde.org/r/1359/diff > > > Testing > ------- > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
