----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1359/#review2114 -----------------------------------------------------------
This was made this way because when you have many contacts in your list, it is annoying to click on the invite button and receive a huge list that doesn't even fit on the screen. This behavior can even make you select the wrong contact by mistake. But this is my opinion, and it would be better to have a second opinion about it before you commit. trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp <http://reviewboard.kde.org/r/1359/#comment1439> I think you can remove this line, as it.value()->isOnline() will filter only the online contacts. - Tiago On 2009-08-19 22:12:43, Aleix Pol wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1359/ > ----------------------------------------------------------- > > (Updated 2009-08-19 22:12:43) > > > Review request for Kopete. > > > Summary > ------- > > Instead of just showing the Online contacts, we show the contacts that are > not offline. > > I'd suggest to backport that to the 4.3 branch as well. > > > This addresses bug 203585. > https://bugs.kde.org/show_bug.cgi?id=203585 > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp 1012131 > > Diff: http://reviewboard.kde.org/r/1359/diff > > > Testing > ------- > > > Thanks, > > Aleix > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
