----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/920/ -----------------------------------------------------------
(Updated 2009-07-04 14:10:50.335247) Review request for Kopete. Summary ------- Drag and hover focus for tabs When links or files are dragged and hovered over the taskbar they pop up the associated window. For other tabbed applications when there is a drag and hoverover a tab that tab is given focus. Kopete should do the same. http://techbase.kde.org/Projects/Kopete/JuniorJobs#Drag_and_hover_focus_for_tabs It work by making the tabs accept the dragEnterEvent and if the user drop the file on the tab the event is sent to the ChatView. Diffs ----- /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.h 990058 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 990058 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h 990058 /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp 990058 Diff: http://reviewboard.kde.org/r/920/diff Testing ------- Sometime KopeteChatWindow::testCanDecode() stop being triggered. When it happen I can't even drop the file on the ChatTextEditPart which I think always accept a dragEnterEvent/dropEvent. I'm not sure if it's a bug in KTabWidget or KTabBar, maybe it's just happening on my side. Thanks, Bruno _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel