Le lundi 27 octobre 2008, Roman Jarosz a écrit : > On Mon, 27 Oct 2008 13:51:30 +0100, Matt Rogers <[EMAIL PROTECTED]> wrote: > > On Monday 27 October 2008 03:08:16 Roman Jarosz wrote: > >> On Mon, 27 Oct 2008 05:00:41 +0100, Matt Rogers <[EMAIL PROTECTED]> wrote: > >> > On Sunday 26 October 2008 16:54:00 Roman Jarosz wrote: > >> >> Hi, > >> >> > >> >> some jabber (gtalk) clients don't send delivery message back so > >> >> the sending notification is turning forever in chat window (bug > >> > >> 173599). > >> > >> >> I've created patch which allows to suppress the sending notification. > >> >> > >> >> Is it ok to commit? I'm asking because I've added code into > >> >> Kopete::Contact > >> >> so other protocols can use it too in future. > >> >> > >> >> Regards, > >> >> Roman > >> > > >> > There isn't a diff attached. It looks like the output of svn st > >> > instead... > >> > >> Oh right :), here is the diff. > > > > Hmm. I don't like this (The concept that is; the code looks fine, of > > course) > > > > XMPP (through an XEP, the number of which I can't remember right now) > > allows > > a client to define whether or not they support the various different > > notifications (typing, etc.) and we should be using that instead of > > adding > > something in libkopete to work around an issue with one protocol. > > I agree if we can detect this we should use it. > Anybody know were I can find it in jabber? Gof?
Well, The situation is a bit complex. There is at least 2 XEP involved: XEP-0022: Message Events (deprecated) XEP-0085: Chat state notification Thoses are mainly used for the typing notification. Kopete support both Anyway, only the XEP-0022 include the sending notification, but this XEP is deprecated and there is AFAIK no real replacement to this. There is no reliable way to know if a client/server support XEP-0022. (if we don't receive notification it probably means it doesn't support) (but on the other hand, if we receive a notification, that means There is also the experimental XEP-0198: Stream Management (Kopete doesn't support it and I don't know any client which support it) which is supposed to be a theorical replacement for the message acknowledgement, but which is not really the same thing at all. Anyway, i don't like the patch either. The disability should be a property of the ChatSession, not of the Contact. I would say that in the case of jabber, an icon should be set when we receive the ack, and the pending notification only if we know the client support it (because we already received ack) Note that for jabber there are 3 different ack: - Message has been received - Message has been displayed - Message has been stored on the server (kopete always mark all message as displayed which is a bit wrong)
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
