Em Tuesday 13 November 2007 21:21:49 Matt Rogers escreveu: > On Nov 13, 2007, at 4:36 PM, Gustavo Pichorim Boiko wrote: > > Hi > > > > Today I've simplified the avatar selector dialog a bit. > > Screenshot at: > > http://people.mandriva.com/~boiko/kopete/avatars/ > > kopete_avatar_dialog.png > > > > Please review the changes. > > > > Cheers > > Comments: > > @@ -175,7 +196,8 @@ > Kopete::AvatarManager::AvatarEntry addedEntry = > Kopete::AvatarManager::self()->add( newEntry ); > if( addedEntry.path.isEmpty() ) > { > - d->mainWidget.labelErrorMessage->setText( i18n("Kopete > cannot add > this new avatar because it could not save the avatar image in user > directory.") ); > + //TODO add a real error message > + //d->mainWidget.labelErrorMessage->setText( > i18n("Kopete cannot > add this new avatar because it could not save the avatar image in > user directory.") ); > return; > } > > Remove the TODO, and change the message so it reads: "Kopete cannot > use this avatar because it could store the metadata required for > using it" or similar.
I put the TODO because the error label that this widget had was not being shown, so the message was just useless. I can use error dialogs instead of that, but not sure it is a good idea (kopete has already many blocking error dialogs), that's why I have kept it as a TODO item (for 4.1 probably). > Otherwise, looks fine. Please make sure you check for signal > connection errors before committing. Already checked. Thanks for reviewing -- Gustavo Pichorim Boiko _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
