On Nov 13, 2007, at 4:36 PM, Gustavo Pichorim Boiko wrote:

Hi

Today I've simplified the avatar selector dialog a bit.
Screenshot at:
http://people.mandriva.com/~boiko/kopete/avatars/ kopete_avatar_dialog.png

Please review the changes.

Cheers

Comments:

@@ -175,7 +196,8 @@
Kopete::AvatarManager::AvatarEntry addedEntry = Kopete::AvatarManager::self()->add( newEntry );
                if( addedEntry.path.isEmpty() )
                {
- d->mainWidget.labelErrorMessage->setText( i18n("Kopete cannot add this new avatar because it could not save the avatar image in user directory.") );
+                       //TODO add a real error message
+ //d->mainWidget.labelErrorMessage->setText( i18n("Kopete cannot add this new avatar because it could not save the avatar image in user directory.") );
                        return;
                }

Remove the TODO, and change the message so it reads: "Kopete cannot use this avatar because it could store the metadata required for using it" or similar.

Otherwise, looks fine. Please make sure you check for signal connection errors before committing.
--
Matt


Attachment: PGP.sig
Description: This is a digitally signed message part

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to