------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.kde.org/show_bug.cgi?id=113525
freebsd chillt de changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14962|0 |1
is obsolete| |
------- Additional Comments From freebsd chillt de 2006-03-06 09:28 -------
Created an attachment (id=14979)
--> (http://bugs.kde.org/attachment.cgi?id=14979&action=view)
*Real* fix for MSN file transfer
Ladies and gentlemen...
After a whole night of logging, packet sniffing, cursing and coding, I present
you... a patch that actually fixes the *real* bug in MSN file transfers.
The real problem was that for a file transfter, the connection INVITE must
*never* be acknowledged or replied to with a 200 OK. It should simply be parsed
for information and then discarded. I know this is documented differently on
websites dealing with the MSN protocol, but this is what the MSN client does
and expects. MSN 7.0 might swallow the 200 OK, MSN 7.5 does not. It starts
sending more INVITEs with increasing port numbers, apparently waiting for a
direct connect or something.
Once the above was fixed, a second problem surfaced. On the first file transfer
between two clients, session and transfer INVITEs must be sent. But on
subsequent connections, the second INVITE may (or must) be omitted. Kopete was
waiting for the second INVITE and although data was being received, it was not
being saved to anywhere. This meant that after only one file transfer per peer
would work. The data received in all later transfers would just get discarded.
Both problems are fixed in the attached patch, which also removes my curde hack
from the previous patch. I have taken great care to affect file transfers only.
Buddy icons seem to be unaffected and transfer fine for me. Webcam I cannot
test due to lack of hard- and software. It could be, of course, that similar
changes are required there at some point.
This patch is dedicated to Phil B who helped me with logging all night. And
it's also dedicated to the unknown lady whose pink boots served as a test jpg
for our file transfers :).
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
