+1. Would definitely recommend to a friend. --Barton
On Fri, Jun 19, 2015 at 11:17 AM, Jesse <pianohac...@gmail.com> wrote: > Definite +1 to this. > > Should we also discuss adding this to the coding standards at the next > development meeting? > > 2015-06-19 8:43 GMT-06:00 Jonathan Druart <jonathan.dru...@biblibre.com>: > >> The discussion started from bug 12598 comment 44. >> For instance, do we want Koha::Patron::Import or Koha::Import::Patron? >> >> 2015-06-19 15:35 GMT+01:00 Kyle Hall <kyle.m.h...@gmail.com>: >> > It's been discussed a few times, but I think we need to formalize naming >> > conventions when writing patches for Koha. >> > >> > The worse offenders are those things that we use many different names >> for >> > both internally and externally. I think patrons/borrowers/members is the >> > worst offender. List come to mind as well ( previously being virtual >> shelves >> > ). >> > >> > I believe that our internal nomenclature should reflect our outward >> > nomenclature. So if the staff and/or OPAC use the term "patron" we >> should be >> > using the term "patron" in our code as well, especially for namespaces. >> > >> > What does everyone think? >> > >> > The more we hammer out now the easier it will be to vote on naming >> rules at >> > the dev meeting. >> > >> > Kyle >> > >> > http://www.kylehall.info >> > ByWater Solutions ( http://bywatersolutions.com ) >> > Meadville Public Library ( http://www.meadvillelibrary.org ) >> > Crawford County Federated Library System ( http://www.ccfls.org ) >> > Mill Run Technology Solutions ( http://millruntech.com ) >> > >> > _______________________________________________ >> > Koha-devel mailing list >> > Koha-devel@lists.koha-community.org >> > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> > website : http://www.koha-community.org/ >> > git : http://git.koha-community.org/ >> > bugs : http://bugs.koha-community.org/ >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel@lists.koha-community.org >> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : http://www.koha-community.org/ >> git : http://git.koha-community.org/ >> bugs : http://bugs.koha-community.org/ >> > > > > -- > Jesse Weaver > > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ >
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/