On 22 September 2013 05:16, Galen Charlton <g...@esilibrary.com> wrote: > Hi, > > On Fri, Sep 20, 2013 at 8:48 PM, Chris Cormack <ch...@bigballofwax.co.nz> > wrote: >> >> One question, would you like the bot to comment if it applied a patch >> cleanly? Or just move on to the next one, (as it is doing now). >> The next thing I plan to add, is having it run the test suite, or at >> least the 00- tests. Would people like it to mark things failed qa if >> the tests fail, or just leave a comment? > > > I think it should make a comment if it successfully applies the patch (or > maybe set a custom last-looked-at-by-bot field?). I also think that it > should set the bug to failed QA if whatever tests are run don't pass, but I > imagine some tweaking will be required so that it doesn't do things like > auto-fail a patch that adds a new dependency -- so maybe it should just add > a comment at first. Once we're confident that it isn't generating false > negatives, then we could have it change the status. > > Will the bot process bugs again after a suitable interval has passed? A > patch that applies today may not apply two months from now if master has > moved on but no human has yet looked at the bug. >
Yeah, it looks at anything in the Needs Signoff queue, that isn't set to be ignored. Chris > Regards, > > Galen > -- > Galen Charlton > Manager of Implementation > Equinox Software, Inc. / The Open Source Experts > email: g...@esilibrary.com > direct: +1 770-709-5581 > cell: +1 404-984-4366 > skype: gmcharlt > web: http://www.esilibrary.com/ > Supporting Koha and Evergreen: http://koha-community.org & > http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
