I think it's a great plan, I've already been caught with one minor rebase requirement and was glad to be prompted by the bot instead of wasting a humans time ;)
Martin Martin Renvoize Software Engineer, PTFS Europe Ltd Content Management and Library Solutions Skype: Landline: 0203 286 8685 Mobile: 07725985636 http://www.ptfs-europe.com On 18 September 2013 15:31, Galen Charlton <g...@esilibrary.com> wrote: > Hi, > > > On Wed, Sep 18, 2013 at 4:37 AM, Chris Cormack > <ch...@bigballofwax.co.nz>wrote: >> >> You may have noticed that there have been a bunch of updates from >> <git...@bugs.koha-community.org> to bugs in 'Needs Signoff' status. >> It is running through all bugs in that status, grabbing the patches >> and applying them, and changing the status if they don't apply clean. >> > > I think this is an excellent idea. > > >> If people find this annoying I will turn it off. If people don't I >> will start on phase 2, which is making it run all the tests after >> applying the patches, and catch any fails. >> > > I think the annoyance factor would mainly depend on how frequently the bot > fails patches incorrectly. I also have a concern about the potential for a > new contributor to post a patch in good faith, only to have their first > interaction with the community be a bot them that their patch is > problematic, but I think we can wait and see how it works out in practice. > > >> My idea is that everything in the 'Needs Signoff' should be passing >> tests and applying cleanly. >> > > Agreed. One caveat, though -- if it isn't doing so already, the bot > should be taking dependent bugs into account when testing whether patches > apply. It failing to do so would quickly turn it into an annoyance. > > Regards, > > Galen > -- > Galen Charlton > Manager of Implementation > Equinox Software, Inc. / The Open Source Experts > email: g...@esilibrary.com > direct: +1 770-709-5581 > cell: +1 404-984-4366 > skype: gmcharlt > web: http://www.esilibrary.com/ > Supporting Koha and Evergreen: http://koha-community.org & > http://evergreen-ils.org > > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ >
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
