Hi, On Fri, Jan 11, 2013 at 9:37 AM, Jared Camins-Esakov < jcam...@cpbibliography.com> wrote:
> Signing off is both checking that a feature works and -- hopefully -- > considering whether there are any bigger problems with it, such as > regressions, to the extent that the developer is able to do this. Unit > tests provide an easy way to test for regressions, which is why it's a good > idea to run them -- if not all of them, at least the relevant ones -- while > signing off. Obviously as RM I do not have the power to mandate that > everyone must run unit tests before signing off, nor would I want to, but I > will say that the more thorough the sign off, the more likely it is that I > will spend time on a patch. Patches with only a perfunctory sign off are > more likely to trigger my "one strike" rule (that's the rule that says the > first problem I encounter with a patch, no matter how minor, can get the > patch failed). > > The QA team should also be running unit tests, of course, but the point of > the sign off/QA divide is that we want more eyes reviewing patches before > they go in. If the developer who signs off is running unit tests, I can > feel pretty confident that they didn't just add a "Signed-off-by" line > before uploading a patch. > I cannot give this enough +1s. QA *must* be considered the responsibility of everybody who regularly submits patches to Koha, not just the QA team. I consider making sure that the tests pass if you submit a patch or if you sign off on one to be the *bare minimum* of what we should expect of ourselves. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: g...@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
