Paul and Jared, It seems that my 'clean' master was not that clean. I do a new clone, and the errors I found on master can be attributed to some missing sample data and a problem I have with Test::Pod::Spelling So now I know what to expect.
Anyway, I was just trying to obey the rules. Thank you both, Bernardo -- Bernardo Gonzalez Kriegel bgkrie...@gmail.com On Fri, Jan 11, 2013 at 2:37 PM, Jared Camins-Esakov <jcam...@cpbibliography.com> wrote: > Paul, > >> OTOH: signing-off is checking that the feature works fine. It's the QA >> team that will be in charge to check unit tests. >> (Of course, if a patch contains a unit test itself, you should not >> signoff until you've successfully run it ;-) ) > > > Signing off is both checking that a feature works and -- hopefully -- > considering whether there are any bigger problems with it, such as > regressions, to the extent that the developer is able to do this. Unit tests > provide an easy way to test for regressions, which is why it's a good idea > to run them -- if not all of them, at least the relevant ones -- while > signing off. Obviously as RM I do not have the power to mandate that > everyone must run unit tests before signing off, nor would I want to, but I > will say that the more thorough the sign off, the more likely it is that I > will spend time on a patch. Patches with only a perfunctory sign off are > more likely to trigger my "one strike" rule (that's the rule that says the > first problem I encounter with a patch, no matter how minor, can get the > patch failed). > > The QA team should also be running unit tests, of course, but the point of > the sign off/QA divide is that we want more eyes reviewing patches before > they go in. If the developer who signs off is running unit tests, I can feel > pretty confident that they didn't just add a "Signed-off-by" line before > uploading a patch. > > Regards, > Jared > > -- > Jared Camins-Esakov > Bibliographer, C & P Bibliography Services, LLC > (phone) +1 (917) 727-3445 > (e-mail) jcam...@cpbibliography.com > (web) http://www.cpbibliography.com/ > > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
