https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42835
--- Comment #87 from Luis Bataller <[email protected]> --- Hi Martin, Here's the split proposal for review before we file anything. The fixes from your review are already on the branch (PR #1), and each of them would go into the bug where the code it fixes is introduced. I've kept the numbering you used in your review (1-38, range 541cbd84a53..cc618963d67). 39-49 are the review fixes. Each bug applies on top of the previous one in the list. 1. Bug 42835 (reused): nested items in the index and reactive reindexing The nested items mapping and indexing (statuses, availability, item count, acquisition date, effective item type), reindexing on hold, transfer and stock rotation changes and the items schema version in the mapping, with a database update warning that the index must be recreated. Commits: 1, 2, 5 (without the geolocation part), 6 (without the hook), 13 (only the test infrastructure), 15, 27, 28, 29, 31, 43, 48 (without the AddReturn part) 2. New bug: library geolocation in the nested items Reindex the records when the geolocation of a library changes, and keep the rest of the query when searching by geolocation. Commits: 5 (geolocation part), 24, 49 3. Bug 43151 (reused): item filters and facets on the same item Item limits, item facets, library limits and availability on the same item, facet counts filtered by the active item filters, the OPAC whitelist of item fields. Availability limit mapped explicitly for Zebra. Commits: 3, 4, 7, 10, 12, 13 (its subtests), 14, 19 (only the extraction of _item_filter_clauses and the facet count filtering), 23 (Elasticsearch part), 39 (without the fields added by bugs 4, 6 and 8), 40 (lost item filter), 44 (without the parts of bugs 4, 5 and 6), 45 4. New bug: advanced search on item fields Item type, collection and location limits, and barcode, call number and acquisition date operands, resolved on the same item. Also covers the limits of saved search filters. Commits: 16, 17, 25, 26, and the operand parts of 39 and 44 5. Bug 35052 (reused): OpacHiddenItems and OpacHiddenItemsHidesRecord in the search Commits: 8, 9, 32, and the item hiding parts of 40 and 44 6. New bug: item_hidden_in_opac and item_available_for_patron plugin hooks The two hooks, items.available_for_patron and its OPAC/staff controls, AllowHoldsOnDamagedItems, and the former OPAC availability control with Zebra. Commits: 6 (hook part), 18, 34, 41, 42, 46, and the available_for_patron parts of 39 and 44 7. New bug: show only the matching items in the staff search results Commits: 19 (inner_hits and the StaffSearchResultsShowOnlyMatchingItems preference) 8. New bug: on-request item filter in the OPAC and staff search Commits: 11, 47, and the onrequest part of 39 9. New bug: MARC field of each item in the nested items, and no embedded items when indexing Commits: 35, 36, 37 (the items schema version constant from 36 moves to bug 42835, with 43) 10. New bug (small, independent of the rest): a Zebra limit to an unknown or empty library group matches nothing Commits: 23 (Zebra part) Left out: - 22 and 30: replaced by Adolfo's bugs 43885 and 43879, along with the AddReturn part of 48. - 20, 21, 33 and 38 (copyright, tidy, return undef, file modes): squashed into the commits they fix. Does this look OK to you? Happy to change anything before we file the new bugs. Thanks! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
