https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500
Matt Blenkinsop <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Matt Blenkinsop <[email protected]> --- Initial QA review: The patches no longer apply cleanly, the review is based on the code at this point, I'll test the functionality once rebased 1) There are a number of strings in the datatables column definition that aren't wrapped in translation methods 2) In the old code we used to coerce the ratio to be a number and ensure it was greater than 0 # Force to be a number $ratio += 0; if ( $ratio <= 0 ) { $ratio = 1; # prevent division by zero } This no longer happens and a 400 error is returned by the API if it isn't >0. Similarly a non-numeric ration will fail swagger validation. Please check we aren't introducing a regression here 3) The old code used GetDescriptionByKohaField( kohafield => 'items.location' / 'items.ccode' ). These are now hardcoded to LOC and CCODE. For most sites this won't be an issue but there could be sites which map those fields to different categories 4) We should really be avoiding raw SQL in object class methods. I appreciate this is a very large, complex query but I think most of it could be written into DBIC with some SQL fragments passed into those queries. Assuming this doesn't slow the page down again, I think it is what we should aim for - if performance issues return then we can reassess -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
