https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39756
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Andrew Fuerste-Henry <[email protected]> --- I've gone through all the test plans except Comment 16, which I should be able to get to tomorrow. Issues so far: On the triggers page, last line in the blue box reads "The system is currently set to match based on the cron" but rule selection is based on the CircControl syspref. As of 26.05, the longoverdue cronjob follows LostChargesControl rather than CircControl (Bug 39802 - Add CircControl equivalent system preference for lost item fees and actions). But with this patch set all circulation triggers are evaluated based on CircControl. Seems like triggers should be evaluated based on CircControl if they do not set a lost value or charge a replacement cost, but evaluated based on LostChargesControl if they do either of these things. If you reload the page while editing a trigger, the page shows a modal with "Loading context" and "Loading rule set information" but never loads Comment 11, step 9: When saving the library-specific trigger with No Notice, the transport types disappeared from the edit modal. But after saving the table of existing rules still shows "Yes" for email. Comment 12: Test failure prove t/db_dependent/Koha/Overdues/ t/db_dependent/Koha/Overdues/ActionExecutor.t .... 1/26 # Failed test 'a charge blocked by the duplicate guard is not counted' # at t/db_dependent/Koha/Overdues/ActionExecutor.t line 323. # got: '2' # expected: '1' t/db_dependent/Koha/Overdues/ActionExecutor.t .... 6/26 # Looks like you failed 1 test of 6. # Failed test 'enact_charge creates LOST debit with caller-resolved branch' # at t/db_dependent/Koha/Overdues/ActionExecutor.t line 326. t/db_dependent/Koha/Overdues/ActionExecutor.t .... 25/26 # Looks like you failed 1 test of 26. t/db_dependent/Koha/Overdues/ActionExecutor.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/26 subtests t/db_dependent/Koha/Overdues/Repository.t ........ ok t/db_dependent/Koha/Overdues/RuleResolver.t ...... ok t/db_dependent/Koha/Overdues/TriggerProcessor.t .. ok Test Summary Report ------------------- t/db_dependent/Koha/Overdues/ActionExecutor.t (Wstat: 256 (exited 1) Tests: 26 Failed: 1) Failed test: 6 Non-zero exit status: 1 Files=4, Tests=51, 16 wallclock secs ( 0.02 usr 0.00 sys + 12.49 cusr 2.63 csys = 15.14 CPU) Result: FAIL Comment 14: In 26.05, if the triggers say the patron should get an email but they have no email address and therefore get a print notice instead, Koha will use the email template if no print template exists. With these patches in that situation Koha does not use the email template and instead makes no notice. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
