https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42310

--- Comment #113 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Created attachment 205894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205894&action=edit
Bug 42310: (follow-up) Make 16.12.00.032 upgrade self-contained

The historical 16.12.00.032 upgrade step (Bug 12063) instantiated
Koha::Calendar to push reserves.expirationdate forward by the max
pickup delay in open days. Depending on a live application class from a
frozen upgrade step is fragile: when this bug renamed and removed
Koha::Calendar, the migration had to be edited to chase the new
namespace.

Frozen updatedatabase.pl steps should be self-contained and prefer
direct DB access. Reimplement the holiday-aware date advance inline,
reading the legacy repeatable_holidays / special_holidays tables (which
still exist at this point in the upgrade path) directly, with no
dependency on any Koha::* calendar class. This keeps the step working
regardless of later refactors and removes the calendar-class reference
from updatedatabase.pl entirely.

The weekly / day-month / single-closure logic and exception (open
override) handling mirror the historical C4::Calendar semantics.

Signed-off-by: Tomás Cohen Arazi <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to