https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42310
--- Comment #116 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Pedro Amorim (ammopt) from comment #112) > Hi all > > Issue 1: cleanup_database.pl script still refers to special_holidays (which > no longer exists after this patchset): > perl misc/cronjobs/cleanup_database.pl --unique-holidays 30 --confirm > DBI Exception: DBD::mysql::st execute failed: Table > 'koha_kohadev.special_holidays' doesn't exist I totally missed that script! I made it use the Koha::Object-based classes now, as the DELETE should be triggering cache invalidation as well! > Issue 2: > kohastructure.sql's comment header above library_repeating_closures still > refers to repeatable_holidays Done. > Issue 3: > The 16.12.00.032 upgrade step (installer/data/mysql/updatedatabase.pl) used > to respect the useDaysMode system preference when advancing a waiting hold's > pickup expiration date past closed days (via > Koha::Library::Calendar->days_forward()). The patch "Make 16.12.00.032 > upgrade self-contained" replaced that with a hand-rolled loop that always > advances 1 day at a time, regardless of useDaysMode, so Dayweek mode's "skip > to the same weekday next week" behaviour is silently gone. > > Steps to reproduce: > A) > perl -MKoha::Library::Calendar -MDateTime -MC4::Context -e ' > C4::Context->set_preference("useDaysMode", "Dayweek"); > my $c = Koha::Library::Calendar->new( branchcode => "MPL", days_mode => > C4::Context->preference("useDaysMode") ); > print $c->get_push_amt( DateTime->now ), "\n"; > ' > B) Output: 7 - this is Koha's real, current calendar logic: pushing forward > 7 days (not 1) when skipping a closed day under Dayweek mode. > C) installer/data/mysql/updatedatabase.pl's 16.12.00.032 step only ever does > $expirationdate->add( days => 1 ) in its closed-day loop, never checking > useDaysMode. Done! > Issue 4 (Non-blocker): > C4::Overdues::GetSpecialHolidays/GetRepeatableHolidays/GetWdayFromItemnumber > still reference the dropped tables via raw SQL, but they're dead code. This > is not something introduced by this patchset, but worth cleaning up while > we're at it imo. Done! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
