https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |[email protected] | |k --- Comment #22 from Pedro Amorim (ammopt) <[email protected]> --- Hi all, failing QA here for a chance at a revisit or response. The commit message is way too long and reads too AI-heavily. The test plan seems excessive. Looking closer, this patch appears to be actually fixing (at least) three distinct issues: 1. The reported bug: blank printer name/paper bin leading to a duplicate-key crash. 2. A separate crash in the patron card editor from clearing a numeric field (offset/creep) under strict SQL modes. 3. A separate crash from a profile being deleted between opening and saving the edit form. My suggestion: break this down into smaller, specific commits, one per issue where practical. Each commit should have a short, concise message of what it does, and one short, easy to follow test plan per bug that is being fixed. Please update the bug title to reflect the full scope, or alternatively keep this bug scoped to the originally reported issue and open separate bug reports for the other two (the latter will also potentially help with backportability) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
