https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052
--- Comment #12 from Chris Nighswonger <[email protected]> --- Thanks for the review, Katrin — both points accepted and addressed in the new attachment. **Tidy:** ours, not the signoff's. `misc/devel/tidy.pl` on both `label-edit-profile.tt` and `edit-profile.tt` now passes clean; the affected block on each was a `<label>` / `<input>` split across two lines that tidy collapses back to one, matching the surrounding style. **Pre-fill:** removed. You're right — the class defaults from `C4::Creators::Profile->new()` were leaking into the input fields on the new-profile form. The new-profile form now renders both inputs empty and marked required (client + server). Values only appear pre-filled when they should: from the DB when editing an existing profile, and from what the user just typed when a validation error redisplays the form so they can correct without re-typing. The class defaults are still there in `C4::Creators::Profile` for callers that construct a profile object without arguments — that's the same territory as the `'Default Printer'` DB column default you flagged, and I agree both belong in a separate bug rather than this one. Test plan step 2 has been rewritten to match: empty inputs are now blocked by the browser first, and a devtools bypass hits the server-side `missing_required` warning. Step 6 no longer mentions arriving pre-filled. Nothing else in the test plan changed. Resubmitting now. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
