https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860
Matt Blenkinsop <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #73 from Matt Blenkinsop <[email protected]> --- Quick review of the new patch - most of the issues now resolved but there is still an issue with updating indicators 1) Create a template and action with the following: - Action: Update existing or add new - Fields: 650 a - Value: 'Test' - Check Use indicators - Set indicator 1 to equal 7 - Ignore indicator 2 2) Create/edit a record to have a 650$a field with the second indicator 0 and value of 'Test' 3) Modify the record using the template. 4) I'd expect to see the first indicator set to 7 so that the 650$a field would now be: 650 7 0 $a Test 5) Instead a new field is created so that you have two 650$a fields, one with the original indicator and a new one with the first indicator set to 0 I think the issue is using the same indicator as both a match value and an update value, we can never update it because the match will always fail so a new field will always be created Another issue is in the form submission - marc_modification_templates.js ln 20-31 sets a _ to a blank ' ' but this happens before the validation checks below it have run. If one of those fails it will return the user to the form but they will be unaware that those fields have changed. This should be moved to after the validation checks so that it only runs once they succeed and the form is ready to submit -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
