https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860
Matt Blenkinsop <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Matt Blenkinsop <[email protected]> --- QA findings: 1) kohastructure.sql ln 4756 there is an additional ');' which will break fresh installs 2) The indicators aren't being passed if the action is 'update_field' - is this a deliberate design choice or has it been missed? Indicators aren't affected using a template when updating as it stands. (C4::MarcModificationTemplates ln 832) 3) C4::MarcModificationTemplates ln 774 the loop skips to the next iteration if no matching field is found but when the action is update_field the _update_subfield method in Koha::SimpleMARC wants to create the subfield if it doesn't exist. This can't happen as we have already skipped through to the next loop iteration so we silently miss out on creating the new field 4) _copy_move_field is setting the indicators before transferring to the new tag. This could crash if the source was a control field - see https://metacpan.org/dist/MARC-Record/source/lib/MARC/Field.pm#L190. The indicators should be set after $new_field->{_tag} to prevent this 5) There's some duplication of logic between toggleCharacterPositionField and toggleIndicatorFields - could toggleCharacterPositionField not just call toggleIndicatorFields to ensure standard application of the logic? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
