https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40445
--- Comment #158 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 198764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198764&action=edit Bug 40445: (follow-up) Show actual cash removed alongside expected on discrepancy The cashup summary modal labelled the per-payment-type cash row "Cash removed from register", but the value came from the session transactions (with CASHUP_SURPLUS/DEFICIT lines excluded), so it represented the *expected* cash, not the amount actually counted at cashup. When a deficit or surplus existed, the reconciliation row appeared as the difference between two figures the user could not both see. Render two rows when surplus_total or deficit_total is set on a completed cashup: "Expected cash total" (from total_grouped) and "Cash removed from register" (from cash_register_actions.amount, already exposed as data.amount). The reconciliation row below now visibly equals the difference. Balanced cashups and the in-progress preview keep the original single-row display, and the negative-cashup branch flips the labels to "Expected cash to add to register" / "Cash added to register". Test plan: 1. Configure a cash register and record a few cash payments. 2. Trigger a cashup, enter the exact expected amount; open the summary modal -- a single "Cash removed from register" row is shown matching the expected total. 3. Repeat with an amount lower than expected -- "Expected cash total" and "Cash removed from register" both appear, and the "Cashup deficit" row is the difference. 4. Repeat with an amount higher than expected -- the actual row exceeds the expected row and "Cashup surplus" matches the gap. Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
