https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40445
--- Comment #156 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 198762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198762&action=edit Bug 40445: (QA follow-up) Add nonce, POD, and test isolation This patch resolves three QA findings on the cashup reconciliation work: * Add a CSP nonce to the inline <style> block in cashup_summary.inc so it is not flagged by the forbidden_patterns check. * Document the private _get_session_end method on Koha::Cash::Register::Cashup so pod_coverage passes. * Mock CashupReconciliationNoteRequired to 0 in t/db_dependent/Koha/Cash/Register/Cashup.t so the test does not depend on the site preference value (it previously failed when the syspref was set to "Require" because surpluses and deficits are created without a reconciliation note in this test). Test plan: 1. Apply the patch. 2. Set CashupReconciliationNoteRequired to "Require". 3. Run prove t/db_dependent/Koha/Cash/Register/Cashup.t -- it should pass. 4. Set CashupReconciliationNoteRequired to "Don't require" and re-run -- it should still pass. 5. Run koha-qa.pl on the bug branch -- pod_coverage on Koha/Cash/Register/Cashup.pm and forbidden_patterns on cashup_summary.inc should now pass. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
