On 9/3/2016 8:42 AM, jp charras wrote: > Le 03/09/2016 à 14:30, Wayne Stambaugh a écrit : >> On 8/31/2016 3:14 PM, Carsten Schoenert wrote: >>> >>> Am 31.08.2016 um 21:08 schrieb Carsten Schoenert: >>> [...] >>> >>> To be more precise >>> >>>> $ git grep -n " _T( \"" >>> >>>> 3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp:143: wxButton* btn_OK >>>> = new wxButton( this, wxID_OK, _T( "OK" ) ); >>>> 3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp:144: wxButton* >>>> btn_Cancel = new wxButton( this, wxID_CANCEL, _T( "Cancel" ) ); >>>> common/dialog_about/aboutinfo.h:97: copyrightText.Replace( _T( >>>> "(c)" ), utf8_copyrightSign ); >>>> common/dialog_about/aboutinfo.h:98: copyrightText.Replace( _T( >>>> "(C)" ), utf8_copyrightSign ); >> >> Does anyone know if the copyright symbol should get translated? I never >> really thought about it but I'm guessing it doesn't. > > I don't think it should be translated (I am talking only as French > translator). > > Moreover, these lines are conditionally compiled: > #if wxUSE_UNICODE > ... > > Just remove this code. > I am pretty sure wxUSE_UNICODE is always true. > Because I don't think kicad can work in ANSI mode (if still exists in > wxWidgets >= 3.0). > > Thanks.
I thought so. I believe as of wx 3.0 we should not be using the wxT() macro for strings that don't need translated. > >> >>>> pcbnew/dialogs/dialog_edit_module_for_BoardEditor.cpp:501: >>>> wxMessageBox( msg, _T( "Edit 3D file name" ) ); >>>> pcbnew/dialogs/dialog_edit_module_for_Modedit.cpp:352: >>>> wxMessageBox( msg, _T( "Edit 3D file name" ) ); >>>> scripting/python_scripting.cpp:290: bool success = >>>> wxPyConvertSwigPtr( result, (void**) &window, _T( "wxWindow" ) ); >>>> scripting/python_scripting.cpp:293: wxASSERT_MSG( success, _T( >>>> "Returned object was not a wxWindow!" ) ); >>> >> >> > > -- Mailing list: https://launchpad.net/~kicad-doc-devs Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-doc-devs More help : https://help.launchpad.net/ListHelp
