Ah, you’re totally right. That escaped my mind (hard to track bug w.r.t. std vs boost). I wasn’t sure how things like that were handled (std vs boost variant also comes to mind).
________________________________ From: Seth Hillbrand <s...@hillbrand.org> Sent: Thursday, July 19, 2018 3:28:43 PM To: Thomas Figueroa Cc: KiCad Developers Subject: Re: [Kicad-developers] [PATCH 1 / 2] Add check to use std::optional Hi Thomas- Thank you for the contribution! Right now KiCad only uses C++11. But once we move up to C++17, we will want to minimize code paths so that everyone sees the same result. Otherwise we risk introducing bugs that _really_ hard to track down. In other words, replacing boost:: with std:: in this case with no #if clause will make sense once the call is made to change up to C++17. Maybe we can do that during v6 development? -S Am Do., 19. Juli 2018 um 12:58 Uhr schrieb Thomas Figueroa <tom_figue...@hotmail.com<mailto:tom_figue...@hotmail.com>>: Hello everyone, my name is Thomas. I’ve posted a few times on here to submit some feedback, but now I have finally mustered the courage to submit stuff for development. This first pair of patches is really just to get a feel for things and get feedback on any issues with my process or potential problems. I look forward to contributing to KiCad as much as it has contributed to me having it for my job 😊 _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers<https://nam04.safelinks.protection.outlook.com/?url=https:%2F%2Flaunchpad.net%2F~kicad-developers&data=02%7C01%7C%7Ccaddaa472dbc4024bce108d5edb640e2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636676289377944842&sdata=jkyWpZ4wK59O%2FdOIgSghxrQqsGdp5cklJ0c9Lr17Wm0%3D&reserved=0> Post to : kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net> Unsubscribe : https://launchpad.net/~kicad-developers<https://nam04.safelinks.protection.outlook.com/?url=https:%2F%2Flaunchpad.net%2F~kicad-developers&data=02%7C01%7C%7Ccaddaa472dbc4024bce108d5edb640e2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636676289377944842&sdata=jkyWpZ4wK59O%2FdOIgSghxrQqsGdp5cklJ0c9Lr17Wm0%3D&reserved=0> More help : https://help.launchpad.net/ListHelp<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.launchpad.net%2FListHelp&data=02%7C01%7C%7Ccaddaa472dbc4024bce108d5edb640e2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636676289377944842&sdata=WRHNjyCTTAUyabE9i8N6%2FX0Gb%2Bwj2acKYqQyWOAxoO8%3D&reserved=0>
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
