https://github.com/torvalds/linux/commit/f6e9ceb7a7fc321a31a9dde93a99b7b4b016a3b3
-- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-oem-5.6 in Ubuntu. https://bugs.launchpad.net/bugs/1909647 Title: xfrm_policy.sh in net from ubuntu_kernel_selftests passed with failed sub-cases Status in ubuntu-kernel-tests: In Progress Status in linux package in Ubuntu: Fix Released Status in linux-oem-5.6 package in Ubuntu: Invalid Status in linux source package in Bionic: Invalid Status in linux-oem-5.6 source package in Bionic: Invalid Status in linux source package in Focal: Fix Released Status in linux-oem-5.6 source package in Focal: In Progress Status in linux source package in Groovy: In Progress Status in linux-oem-5.6 source package in Groovy: Invalid Status in linux source package in Hirsute: Fix Released Status in linux-oem-5.6 source package in Hirsute: Invalid Bug description: [Impact] Even with failed cases reported in the xfrm_policy.sh test, the overall result is still "PASS" $ sudo ./xfrm_policy.sh # selftests: net: xfrm_policy.sh # PASS: policy before exception matches # FAIL: expected ping to .254 to fail (exceptions) # PASS: direct policy matches (exceptions) # PASS: policy matches (exceptions) # FAIL: expected ping to .254 to fail (exceptions and block policies) # PASS: direct policy matches (exceptions and block policies) # PASS: policy matches (exceptions and block policies) # FAIL: expected ping to .254 to fail (exceptions and block policies after hresh changes) # PASS: direct policy matches (exceptions and block policies after hresh changes) # PASS: policy matches (exceptions and block policies after hresh changes) # FAIL: expected ping to .254 to fail (exceptions and block policies after hthresh change in ns3) # PASS: direct policy matches (exceptions and block policies after hthresh change in ns3) # PASS: policy matches (exceptions and block policies after hthresh change in ns3) # FAIL: expected ping to .254 to fail (exceptions and block policies after htresh change to normal) # PASS: direct policy matches (exceptions and block policies after htresh change to normal) # PASS: policy matches (exceptions and block policies after htresh change to normal) # PASS: policies with repeated htresh change ok 12 selftests: net: xfrm_policy.sh $ echo $? 0 This is because of the variable "lret" in check_xfrm() is not a local variable, and it looks like it will override the one in check_exceptions() thus making the return value become 0 for the passed test case after the failed one. [Fix] * f6e9ceb7a7fc32 (" selftests: xfrm: fix test return value override issue in xfrm_policy.sh") This patch can be cherry-picked into all of the affected kernels. Focal kernel got this patch via stable update, and we don't have this test in Bionic. [Test] Run the xfrm_policy.sh test, if there is any failed cases the final result will not be 0. [Regression Potential] This change is just for testing tools, it's unlikely to affect real kernel functionality. However it's expected to generate failures in our test report as it's reflecting the real test result. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1909647/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
