On lundi 17 juillet 2017 11:21:29 CEST Ralf Habacker wrote:
> -target_link_libraries(KF5Auth PRIVATE Qt5::Widgets Qt5::DBus)
> +target_link_libraries(KF5Auth PRIVATE Qt5::Widgets ${DBUS_LIBRARY})If this means KAuth doesn't use DBus (on some platforms), then the proper fix would be to only link to DBus on the platforms where this is needed. A cmake option isn't needed, if there's no code that needs to be disabled. Assuming the Windows and OSX implementations don't use DBus (this must be the case, otherwise your patch would break things) then the proper logic would be if (UNIX) require DBus link to DBus enable autotests that require DBus endif() -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
