----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129590/#review101885 -----------------------------------------------------------
Looks good, just one comment. autotests/CMakeLists.txt (line 5) <https://git.reviewboard.kde.org/r/129590/#comment68158> Better split this into two, to avoid confusing people. - David Faure On Nov. 30, 2016, 9:59 a.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129590/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 9:59 a.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kauth > > > Description > ------- > > This adds an `ENABLE_DBUS` CMake option defaulting to `ON`, which can be used > to make KAuth not depend on DBus. This is useful for some apps that are > running on Windows. > > https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg34246.html > > > Diffs > ----- > > CMakeLists.txt b8b7ba7 > autotests/CMakeLists.txt b53d760 > src/CMakeLists.txt 1b6930d > > Diff: https://git.reviewboard.kde.org/r/129590/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
