> On Oct. 8, 2016, 1:43 p.m., Anthony Fieroni wrote: > > kde-modules/KDECompilerSettings.cmake, line 201 > > <https://git.reviewboard.kde.org/r/128779/diff/2/?file=481539#file481539line201> > > > > This and below one must be c++11 or even c++1y ?
This wasn't added by me, so i'd restrain from touching this in my patch. - Gleb ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128779/#review99844 ----------------------------------------------------------- On Oct. 12, 2016, 2:57 p.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128779/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 2:57 p.m.) > > > Review request for Extra Cmake Modules and kdewin. > > > Repository: extra-cmake-modules > > > Description > ------- > > By simply using `if(CMAKE_COMPILER_ID STREQUAL "Clang")` check is not enough > for clang-cl, as it turns on various '-style' flags and omits MSVC's '/style' > flags. > > With this patch i managed to compile much of KF5 up to konversation and kate. > > Known problems: `-std=gnu++98` flag is still appended, but i wasn't able to > figure out why. > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake dfa29f7 > kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 > > Diff: https://git.reviewboard.kde.org/r/128779/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
