----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128779/ -----------------------------------------------------------
(Updated Oct. 12, 2016, 2:57 p.m.) Review request for Extra Cmake Modules and kdewin. Changes ------- Hopefully fixed broken tests. The problem was with `if(CLANG_AS_MSVC)` expression. It was treated as string constant by CMake, thus evaluating to true. I've tested this on FreeBSD, and tests now work. Repository: extra-cmake-modules Description ------- By simply using `if(CMAKE_COMPILER_ID STREQUAL "Clang")` check is not enough for clang-cl, as it turns on various '-style' flags and omits MSVC's '/style' flags. With this patch i managed to compile much of KF5 up to konversation and kate. Known problems: `-std=gnu++98` flag is still appended, but i wasn't able to figure out why. Diffs (updated) ----- kde-modules/KDECompilerSettings.cmake dfa29f7 kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 Diff: https://git.reviewboard.kde.org/r/128779/diff/ Testing ------- Thanks, Gleb Popov
