https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283847
--- Comment #2 from Daniel Engberg <dii...@freebsd.org> --- (In reply to Jason E. Hale from comment #1) They're tools not rules and Porters Handbook also mentions that they're not to be treated as such. Some suggestions just makes things akward/hard to read/follow and isn't followed overall in the tree due to that. Such as not separating USE_GITHUB which is done all the time so changed consistency with the rest of the tree. Feel free to revert whatever changes you disagree upon. While out of scope for the PR placement suggestions of CONFIGURE_* CMAKE_* MESON_* is also one thing that we don't adhere to what our tools suggests because of convenience and ease of reviewing. While not in this case these are more often than not placed last before defining menu options as these often are related to variables in some way or another while tooling wants these sections in alphabetical order which results in a lot jumping back and forth in the text. I have yet to find someone who objects to this layout. This also why CMAKE_TESTING* isn't grouped together in many cases. Comments are unnecessary now that we have a working unit test? People also seem to prefer that comments are left in commit message rather than cluttering the Makefile? -- You are receiving this mail because: You are the assignee for the bug.
