https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283847
Jason E. Hale <jh...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|New |Open
CC| |jh...@freebsd.org
Flags|maintainer-feedback?(kde@Fr |maintainer-feedback+
|eeBSD.org) |
--- Comment #1 from Jason E. Hale <jh...@freebsd.org> ---
Please try to reasonably comply with the corrections given by portclippy(1) and
portlint(1), especially for ports maintained by teams unless otherwise
specified. Some tooling decisions are dumb and should be ignored and/or
corrected, but when multiple people are working on the same port, agreeing with
the dumb tool might be the better option as apposed to unnecessary repo churn
between updates until said tool is brought up to speed.
USE_GITHUB clearly belongs in the USE_ block. No reason to change this. While I
can see a case for moving it to a separate block if GH_ variables are also
defined, this is not true here. Please revert this line's position in the
Makefile.
CMAKE_TESTING_ON shouldn't be a separate block. It should be part of the CMAKE_
block, but should be listed towards the end, because testing is done at the end
of the process. portclippy(1) actually gets this right. Whitespace alignment
within that block would be needed, but that change would be preferable to a
separate block.
Why nuke the useful comments for the CMAKE_OFF variable in the Makefile,
either? Again, this is a team port, so verbosity within the Makefile and
patches is an absolute virtue.
--
You are receiving this mail because:
You are the assignee for the bug.
