dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Thanks for the extensive research! INLINE COMMENTS > kemailaddress.cpp:608 > > bool tooManyAtsFlag = false; > bool inQuotedString = false; [pre-existing: this bool is never set to true....] > kemailaddress.cpp:643 > + const QRegularExpression rx(QRegularExpression::anchoredPattern(addrRx) > + , > QRegularExpression::UseUnicodePropertiesOption); > + return rx.match(aStr).hasMatch() && !tooManyAtsFlag; A bit weird that this comma isn't at the end of the previous line instead :) REPOSITORY R270 KCodecs BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns