dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > dfaure wrote in kemailaddress.cpp:639 > `{,3}` would be `{0,3}`, not `{1,3}` > > Would this allow to minimize the amount of changes made here? I'm worried > about regressions. I'm confused, you still have `1,3` here, rather than `0,3` REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26123 To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns