davidedmundson updated this revision to Diff 71329. davidedmundson added a comment.
Implement new arguments for filterAcceptsRow passing source_row, source_parent. It makes for slightly heavier messier JS, but it also allows for super flexibility beyond just having the value retried and it's familiar for Qt programmers. Maybe we should add an invokable sourceData(int source_row, int source_column, QModelIndex source_parent) to save a bit of boilerplate? REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25326?vs=71327&id=71329 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25326 AFFECTED FILES autotests/CMakeLists.txt autotests/ksortfilterproxymodel_qml.cpp autotests/ksortfilterproxymodeltest.qml src/qml/CMakeLists.txt src/qml/ksortfilterproxymodel.cpp src/qml/ksortfilterproxymodel.h src/qml/plugin.cpp To: davidedmundson Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
