dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kaboutapplicationdialog.cpp:72
> q->setWindowTitle(i18n("About %1", aboutData.displayName()));
> q->setModal(false);
>
(this line does nothing, dialogs aren't modal by default)
> kaboutplugindialog.cpp:78
> + q->setWindowTitle(i18n("About %1", pluginMetaData.name()));
> + q->setModal(false);
> +
(this line does nothing, dialogs aren't modal by default)
REPOSITORY
R263 KXmlGui
BRANCH
addaboutplugindialog
REVISION DETAIL
https://phabricator.kde.org/D25058
To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
