kossebau marked 3 inline comments as done. kossebau added inline comments. INLINE COMMENTS
> dfaure wrote in kaboutplugindialog.cpp:119 > (I'm surprised by the explicit '&' in all those labels, doesn't > KAcceleratorManager take care of this automatically?) Seems it does. So removing then while moving the code. > dfaure wrote in klicensedialog_p.cpp:72 > Well, the code calls `resize` and then `adjustSize`, which calls `resize` > itself. So at least one issue is that one of those two calls is redundant. > Try removing `adjustSize`? Thanks for investigating. Seems indeed removing `adjustSize` brings (back) the intended size :) REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25058 To: kossebau, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
