ndavis added a comment.

  In D25123#558353 <https://phabricator.kde.org/D25123#558353>, @mglb wrote:
  
  > Breaking nice-looking proportions just to fill vertical space is not good 
IMO. Making the bar a bit higher might make it look more reasonably. Your 
second proposition (icon C) looks nice though.
  
  
  I agree, the modified `A` didn't turn out that well.
  
  > Note that size is perceived differently on different shapes - compare e.g. 
square and circle - with the same logical sizes, circle looks smaller (Breeze 
has this problem).
  >  The icon C is 48px wide (44px when counting only the screen), so 36px 
(38px with "handle" on the bottom) height makes its sizes visually similar to 
40x40px square icons.
  > 
  > The same applies for alignment (see e.g. plasmadiscover.svg), but that 
shouldn't be a problem here.
  
  I'm aware of that. I know Material Design uses different sizes for circles, 
squares and rectangles for that reason. Unfortunately, switching to that system 
means we would need to change many icons. I believe the reason why we use the 
system we use is because of horizontal text alignment, but I think that matters 
more for monochrome icons than color icons. On the other hand, nothing actually 
lines up with text in a way that stands out as lining up particularly well 
whether you choose 10, 11 or 12pt Noto Sans.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, 
vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

Reply via email to