ngraham added a comment.
In D25123#558205 <https://phabricator.kde.org/D25123#558205>, @ndavis wrote: > #vdg <https://phabricator.kde.org/tag/vdg/>, Should we allow some types of icons to be vertically off center? If not that, should we allow some icons to not reach all the way to the top and bottom margins? There are already some icons like that, but that doesn't necessarily mean we should want that. I don't think we should allow vertically off-center icons. The only reason to do this is to align the baselines of all icons, but that's only useful for horizontal rows of icons and looks bad with vertical columns of icons or anytime an icon is put within a container that is centered. I recently fixed a bug report about non-centered icons that shows the problems arising from this: https://bugs.kde.org/show_bug.cgi?id=393550 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: ndavis, KonqiDragon, ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns
