apol added a comment.
+1 makes a lot of sense overall. INLINE COMMENTS > filecopyjob.h:74 > bool doResume() override; > - bool doKill() override; > I don't think this change is ABI compatible (though after reading the docs, I'm not 100% sure). https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B You could always define it to call the parent though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
