dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
Nice, I didn't realize the slave had 5 seconds to cleanup after being killed, I thought it died immediately (genericsig_handler in slavebase.cpp). Hmm, the Windows code is probably a no-op then, there's no signal handler there to call setKillFlags(), so no opportunity to cleanup before dying. Some research indicates that we'd have to use `SetConsoleCtrlHandler` on Windows for similar behaviour. https://stackoverflow.com/questions/2007516/is-there-a-posix-sigterm-alternative-on-windows-a-gentle-kill-for-console-ap https://danielkaes.wordpress.com/2009/06/04/how-to-catch-kill-events-with-python/ OK so at least it seems feasible, so I won't object to the commit even if it doesn't implement it on Windows. -1 just for the missing QVERIFY. INLINE COMMENTS > jobtest.cpp:2171 > + > + spyResult.wait(500); > QVERIFY(!QFile::exists(destToCheck)); Always use QVERIFY() around spy.wait(). Well, I'm assuming we actually expect the signal to be emitted :-) I would also remove the 500 then, the default value will be fine. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
