ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcmoduleproxy.cpp:196-197
> Why emit changed?
> 
> Given KCModuleProxy mirrors KCModule API I would have expected a defaulted 
> signal to match?

Because all the consumers I found surprisingly don't care about the distinction 
or the value of that bool. Also it would have led to more intrusive changes in 
said consumers. I admit I was surprised about that.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25071

To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to