davidedmundson added inline comments.

INLINE COMMENTS

> kcmoduleproxy.cpp:196-197
> +    defaulted = d;
> +    emit q->changed(changed);
> +    emit q->changed(q);
> +}

Why emit changed?

Given KCModuleProxy mirrors KCModule API I would have expected a defaulted 
signal to match?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25071

To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to