pajamapants3000 added inline comments. INLINE COMMENTS
> elvisangelaccio wrote in krichtextwidget.cpp:638 > Ah of course. I didn't notice it was `exec()` that was being called. Coming back after two months, even I thought this looked wrong at first. I will endeavor to make my intent clearer, thank you :) > broulik wrote in ktextedit.cpp:373 > You can do `dialog->setAttribute(Qt::WA_DeleteOnClose);` when creating the > dialog instead of an explicit delete call Thank you broulik! Could we use a `QScopedPointer` here? I see them throughout the KDE source, but not often for dialogs. The krazy analysis looked for `QPointer`, referencing blog https://blogs.kde.org/node/3919, which appears to have predated the existence of `QScopedPointer`. REPOSITORY R310 KTextWidgets BRANCH krazy-50b2564 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21897 To: pajamapants3000, elvisangelaccio Cc: broulik, vkrause, elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
