elvisangelaccio accepted this revision. elvisangelaccio added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > vkrause wrote in krichtextwidget.cpp:638 > This is unusual, but it's the right way around. The point of this is to check > if the dialog has been deleted during the sub-eventloop behind exec(). No > idea if that can happen here though, but that's generally the idea behind > this pattern. Ah of course. I didn't notice it was `exec()` that was being called. REPOSITORY R310 KTextWidgets BRANCH krazy-50b2564 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21897 To: pajamapants3000, elvisangelaccio Cc: vkrause, elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns