apol added a comment.
+1 looks good to me besides the nitpick.
INLINE COMMENTS
> kfilewidget.cpp:594
> // the Filter label/edit
> - whatsThisText = i18n("<qt>This is the filter to apply to the file list. "
> - "File names that do not match the filter will not
> be shown.<p>"
> - "You may select from one of the preset filters in
> the "
> - "drop down menu, or you may enter a custom filter "
> - "directly into the text area.</p><p>"
> - "Wildcards such as * and ? are allowed.</p></qt>");
> - d->filterLabel = new QLabel(i18n("&Filter:"), this);
> - d->filterLabel->setWhatsThis(whatsThisText);
> + d->filterLabel = new QLabel;
> d->filterWidget = new KFileFilterCombo(this);
Pass this as parent, I guess when it's added to the layouts somehow it will get
reparented, but I'd say it's a good practice.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20964
To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
