apol added inline comments.

INLINE COMMENTS

> ngraham wrote in kfilewidget.cpp:745
> I did it in `setMimeFilter` since that's where it's determined whether or not 
> there's a limited assortment of mimetypes, which is what controls what the 
> string should be. Conditionalizing it based on mode seemed safe enough 
> considering that there's mode-specific code a few lines above, on 741.

::setOperationMode would need to update that as well, no? Then it would need 
splitting into a separate function, otherwise 
setOperationMode(Saving); setOperationMode(Opening) will have the wrong 
behaviour.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to