zzag added inline comments.
INLINE COMMENTS
> eglstream_controller_interface.cpp:103
> +{
> + dynamic_cast<Private &>(*d).create();
> +}
Can we avoid dynamic casting a reference? Is it possible to use static_cast
instead?
> eglstream_controller_interface_p.h:33
> +
> +class EglStreamControllerInterface::Private : public Global::Private
> +{
Should be marked with Q_DECL_HIDDEN.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D18824
To: ekurzinger, romangg, davidedmundson, #kwin
Cc: zzag, ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel,
michaelh, bruns
